ref: improve handling for room destroyed events (#13591)

* ref: improve handling for room destroyed events

* add missing translation

* code review

* implement kick handling

* implement native handling

* fix tests

* code review changes

* add dialog testId

* fix end conf for react native

* fix lobby test

* add translation for lobby closing

---------

Co-authored-by: Gabriel Borlea <gabriel.borlea@8x8.com>
This commit is contained in:
Avram Tudor
2023-08-28 15:14:03 +03:00
committed by GitHub
parent 509cf661f5
commit 974e2a5106
18 changed files with 272 additions and 122 deletions

View File

@@ -60,6 +60,10 @@ const useStyles = makeStyles()(theme => {
}
},
title: {
fontSize: '16px'
},
details: {
'& textarea': {
minHeight: '122px'
@@ -98,6 +102,11 @@ interface IProps {
* Callback invoked when {@code FeedbackDialog} is unmounted.
*/
onClose: Function;
/**
* The title to display in the dialog. Usually the reason that triggered the feedback.
*/
title?: string;
}
/**
@@ -108,7 +117,7 @@ interface IProps {
* @param {IProps} props - Component's props.
* @returns {JSX}
*/
const FeedbackDialog = ({ conference, onClose }: IProps) => {
const FeedbackDialog = ({ conference, onClose, title }: IProps) => {
const { classes } = useStyles();
const dispatch = useDispatch();
const { t } = useTranslation();
@@ -284,6 +293,7 @@ const FeedbackDialog = ({ conference, onClose }: IProps) => {
size = 'large'
titleKey = 'feedback.rateExperience'>
<div className = { classes.dialog }>
{title ? <div className = { classes.title }>{t(title)}</div> : null}
<div className = { classes.rating }>
<div
className = { classes.stars }