diff --git a/conference.js b/conference.js index 01a3a95caf..f6c5c77dbe 100644 --- a/conference.js +++ b/conference.js @@ -24,7 +24,6 @@ import { reloadWithStoredParams } from './react/features/app/actions'; import { - AVATAR_ID_COMMAND, AVATAR_URL_COMMAND, EMAIL_COMMAND, authStatusChanged, @@ -169,7 +168,6 @@ window.JitsiMeetScreenObtainer = { * Known custom conference commands. */ const commands = { - AVATAR_ID: AVATAR_ID_COMMAND, AVATAR_URL: AVATAR_URL_COMMAND, CUSTOM_ROLE: 'custom-role', EMAIL: EMAIL_COMMAND, @@ -2136,16 +2134,6 @@ export default { })); }); - room.addCommandListener(this.commands.defaults.AVATAR_ID, - (data, from) => { - APP.store.dispatch( - participantUpdated({ - conference: room, - id: from, - avatarID: data.value - })); - }); - APP.UI.addListener(UIEvents.NICKNAME_CHANGED, this.changeLocalDisplayName.bind(this)); diff --git a/react/features/base/conference/actions.js b/react/features/base/conference/actions.js index f59cb64518..5285b6b0bb 100644 --- a/react/features/base/conference/actions.js +++ b/react/features/base/conference/actions.js @@ -52,7 +52,6 @@ import { SET_START_MUTED_POLICY } from './actionTypes'; import { - AVATAR_ID_COMMAND, AVATAR_URL_COMMAND, EMAIL_COMMAND, JITSI_CONFERENCE_URL_KEY @@ -198,13 +197,6 @@ function _addConferenceListeners(conference, dispatch) { botType }))); - conference.addCommandListener( - AVATAR_ID_COMMAND, - (data, id) => dispatch(participantUpdated({ - conference, - id, - avatarID: data.value - }))); conference.addCommandListener( AVATAR_URL_COMMAND, (data, id) => dispatch(participantUpdated({ diff --git a/react/features/base/conference/constants.js b/react/features/base/conference/constants.js index fcb13302f7..70f2581aab 100644 --- a/react/features/base/conference/constants.js +++ b/react/features/base/conference/constants.js @@ -1,10 +1,3 @@ -/** - * The command type for updating a participant's avatar ID. - * - * @type {string} - */ -export const AVATAR_ID_COMMAND = 'avatar-id'; - /** * The command type for updating a participant's avatar URL. * diff --git a/react/features/base/conference/functions.js b/react/features/base/conference/functions.js index 2c39dd8bde..0cbf634b54 100644 --- a/react/features/base/conference/functions.js +++ b/react/features/base/conference/functions.js @@ -14,7 +14,6 @@ import { toState } from '../redux'; import { safeDecodeURIComponent } from '../util'; import { - AVATAR_ID_COMMAND, AVATAR_URL_COMMAND, EMAIL_COMMAND, JITSI_CONFERENCE_URL_KEY @@ -316,16 +315,12 @@ export function sendLocalParticipant( setDisplayName: Function, setLocalParticipantProperty: Function }) { const { - avatarID, avatarURL, email, features, name } = getLocalParticipant(stateful); - avatarID && conference.sendCommand(AVATAR_ID_COMMAND, { - value: avatarID - }); avatarURL && conference.sendCommand(AVATAR_URL_COMMAND, { value: avatarURL }); diff --git a/react/features/base/participants/middleware.js b/react/features/base/participants/middleware.js index 01cac6f900..f6762afa92 100644 --- a/react/features/base/participants/middleware.js +++ b/react/features/base/participants/middleware.js @@ -283,7 +283,6 @@ function _localParticipantJoined({ getState, dispatch }, next, action) { const settings = getState()['features/base/settings']; dispatch(localParticipantJoined({ - avatarID: settings.avatarID, avatarURL: settings.avatarURL, email: settings.email, name: settings.displayName diff --git a/react/features/base/participants/reducer.js b/react/features/base/participants/reducer.js index cf6438a19a..48e224da99 100644 --- a/react/features/base/participants/reducer.js +++ b/react/features/base/participants/reducer.js @@ -181,7 +181,6 @@ function _participant(state: Object = {}, action) { */ function _participantJoined({ participant }) { const { - avatarID, avatarURL, botType, connectionStatus, @@ -211,7 +210,6 @@ function _participantJoined({ participant }) { } return { - avatarID, avatarURL, botType, conference, diff --git a/react/features/base/settings/actionTypes.js b/react/features/base/settings/actionTypes.js index 9228457c92..38b1a8d74c 100644 --- a/react/features/base/settings/actionTypes.js +++ b/react/features/base/settings/actionTypes.js @@ -5,7 +5,6 @@ * type: SETTINGS_UPDATED, * settings: { * audioOutputDeviceId: string, - * avatarID: string, * avatarURL: string, * cameraDeviceId: string, * displayName: string, diff --git a/react/features/base/settings/actions.js b/react/features/base/settings/actions.js index 5f138730fa..76ec67d148 100644 --- a/react/features/base/settings/actions.js +++ b/react/features/base/settings/actions.js @@ -8,7 +8,6 @@ import { SETTINGS_UPDATED } from './actionTypes'; * type: SETTINGS_UPDATED, * settings: { * audioOutputDeviceId: string, - * avatarID: string, * avatarURL: string, * cameraDeviceId: string, * displayName: string, diff --git a/react/features/base/settings/reducer.js b/react/features/base/settings/reducer.js index a52412e5be..18e006dd6a 100644 --- a/react/features/base/settings/reducer.js +++ b/react/features/base/settings/reducer.js @@ -1,7 +1,6 @@ // @flow import { jitsiLocalStorage } from '@jitsi/js-utils'; -import { randomHexString } from '@jitsi/js-utils/random'; import _ from 'lodash'; import { APP_WILL_MOUNT } from '../app/actionTypes'; @@ -19,7 +18,6 @@ import logger from './logger'; */ const DEFAULT_STATE = { audioOutputDeviceId: undefined, - avatarID: undefined, avatarURL: undefined, cameraDeviceId: undefined, disableCallIntegration: undefined, @@ -126,24 +124,16 @@ function _initSettings(featureState) { // jibri, and remove the old settings.js values. const savedDisplayName = jitsiLocalStorage.getItem('displayname'); const savedEmail = jitsiLocalStorage.getItem('email'); - let avatarID = _.escape(jitsiLocalStorage.getItem('avatarId')); // The helper _.escape will convert null to an empty strings. The empty // string will be saved in settings. On app re-load, because an empty string // is a defined value, it will override any value found in local storage. // The workaround is sidestepping _.escape when the value is not set in // local storage. - const displayName - = savedDisplayName === null ? undefined : _.escape(savedDisplayName); + const displayName = savedDisplayName === null ? undefined : _.escape(savedDisplayName); const email = savedEmail === null ? undefined : _.escape(savedEmail); - if (!avatarID) { - // if there is no avatar id, we generate a unique one and use it forever - avatarID = randomHexString(32); - } - settings = assignIfDefined({ - avatarID, displayName, email }, settings);