From cfcc3fdbbe2b3db66d0c3a44ce44dcfffa9e0746 Mon Sep 17 00:00:00 2001 From: Hristo Terezov Date: Mon, 13 Nov 2023 10:55:32 -0600 Subject: [PATCH] fix(FeedbackButoon): display for JaaS meetings. --- react/features/feedback/components/FeedbackButton.web.ts | 7 ++++--- react/features/feedback/functions.web.ts | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/react/features/feedback/components/FeedbackButton.web.ts b/react/features/feedback/components/FeedbackButton.web.ts index 32ab6aad0f..3db48d527d 100644 --- a/react/features/feedback/components/FeedbackButton.web.ts +++ b/react/features/feedback/components/FeedbackButton.web.ts @@ -9,6 +9,7 @@ import { translate } from '../../base/i18n/functions'; import { IconFeedback } from '../../base/icons/svg'; import AbstractButton, { IProps as AbstractButtonProps } from '../../base/toolbox/components/AbstractButton'; import { openFeedbackDialog } from '../actions'; +import { shouldSendJaaSFeedbackMetadata } from '../functions.web'; /** * The type of the React {@code Component} props of {@link FeedbackButton}. @@ -45,11 +46,11 @@ class FeedbackButton extends AbstractButton { } const mapStateToProps = (state: IReduxState) => { - const { callStatsID } = state['features/base/config']; + const { conference } = state['features/base/conference']; return { - _conference: state['features/base/conference'].conference, - visible: Boolean(callStatsID) + _conference: conference, + visible: conference?.isCallstatsEnabled() || shouldSendJaaSFeedbackMetadata(state) }; }; diff --git a/react/features/feedback/functions.web.ts b/react/features/feedback/functions.web.ts index 7293c4b1f7..96aea74286 100644 --- a/react/features/feedback/functions.web.ts +++ b/react/features/feedback/functions.web.ts @@ -65,6 +65,6 @@ export async function sendFeedbackToJaaSRequest(url: string | undefined, feedbac export function shouldSendJaaSFeedbackMetadata(state: IReduxState) { const { jaasFeedbackMetadataURL } = state['features/base/config']; - return isVpaasMeeting(state) && jaasFeedbackMetadataURL; + return Boolean(isVpaasMeeting(state) && jaasFeedbackMetadataURL); }