ZF/jitsi-meet
1
0
Fork 0
mirror of https://gitcode.com/GitHub_Trending/ji/jitsi-meet.git synced 2025-12-30 03:12:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(transcriptions): Drops not needed parameter.

Browse Source 
Fixes an issue with iFrameAPI where toggleSubtitles will not do anything in case of async transcriptions turned on.
This commit is contained in:
damencho
2025-12-29 11:33:18 -06:00
committed by Дамян Минков
parent 47aa51a58c
commit ddaf7a3180
6 changed files with 12 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/API/API.js
View File

@@ -790,7 +790,7 @@ function initCommands() {
}
if (transcription) {
APP.store.dispatch(setRequestingSubtitles(true, false, null, true));
APP.store.dispatch(setRequestingSubtitles(true, false, null));
}
},
@@ -812,7 +812,7 @@ function initCommands() {
}
if (transcription) {
APP.store.dispatch(setRequestingSubtitles(false, false, null, true));
APP.store.dispatch(setRequestingSubtitles(false, false, null));
}
if (mode === 'local') {

4
react/features/mobile/external-api/middleware.ts
View File

@@ -588,7 +588,7 @@ function _registerForNativeEvents(store: IStore) {
}
if (transcription) {
store.dispatch(setRequestingSubtitles(true, false, null, true));
store.dispatch(setRequestingSubtitles(true, false, null));
}
});
@@ -603,7 +603,7 @@ function _registerForNativeEvents(store: IStore) {
}
if (transcription) {
store.dispatch(setRequestingSubtitles(false, false, null, true));
store.dispatch(setRequestingSubtitles(false, false, null));
}
if (![ JitsiRecordingConstants.mode.FILE, JitsiRecordingConstants.mode.STREAM ].includes(mode)) {

2
react/features/recording/actions.any.ts
View File

@@ -459,7 +459,7 @@ export function showStartRecordingNotificationWithCallback(openRecordingDialog:
});
if (autoTranscribeOnRecord) {
dispatch(setRequestingSubtitles(true, false, null, true));
dispatch(setRequestingSubtitles(true, false, null));
}
} else {
openRecordingDialog();

2
react/features/recording/components/Recording/AbstractStartRecordingDialog.ts
View File

@@ -415,7 +415,7 @@ class AbstractStartRecordingDialog extends Component<IProps, IState> {
if (this.state.selectedRecordingService === RECORDING_TYPES.JITSI_REC_SERVICE
&& this.state.shouldRecordTranscription) {
dispatch(setRequestingSubtitles(true, _displaySubtitles, _subtitlesLanguage, true));
dispatch(setRequestingSubtitles(true, _displaySubtitles, _subtitlesLanguage));
} else {
_conference?.getMetadataHandler().setMetadata(RECORDING_METADATA_ID, {
isTranscribingEnabled: this.state.shouldRecordTranscription

4
react/features/subtitles/actions.any.ts
View File

@@ -95,11 +95,9 @@ export function toggleRequestingSubtitles() {
export function setRequestingSubtitles(
enabled: boolean,
displaySubtitles = true,
language: string | null = `translation-languages:${DEFAULT_LANGUAGE}`,
backendRecordingOn = false) {
language: string | null = `translation-languages:${DEFAULT_LANGUAGE}`) {
return {
type: SET_REQUESTING_SUBTITLES,
backendRecordingOn,
displaySubtitles,
enabled,
language

13
react/features/subtitles/middleware.ts
View File

@@ -98,7 +98,7 @@ MiddlewareRegistry.register(store => next => action => {
break;
}
case SET_REQUESTING_SUBTITLES:
_requestingSubtitlesChange(store, action.enabled, action.language, action.backendRecordingOn);
_requestingSubtitlesChange(store, action.enabled, action.language);
break;
}
@@ -344,17 +344,16 @@ function _getPrimaryLanguageCode(language: string) {
* @param {Store} store - The redux store.
* @param {boolean} enabled - Whether subtitles should be enabled or not.
* @param {string} language - The language to use for translation.
* @param {boolean} backendRecordingOn - Whether backend recording is on or not.
* @private
* @returns {void}
*/
function _requestingSubtitlesChange(
{ dispatch, getState }: IStore,
enabled: boolean,
language?: string | null,
backendRecordingOn = false) {
language?: string | null) {
const state = getState();
const { conference } = state['features/base/conference'];
const backendRecordingOn = conference?.getMetadataHandler()?.getMetadata()?.asyncTranscription;
conference?.setLocalParticipantProperty(
P_NAME_REQUESTING_TRANSCRIPTION,
@@ -363,7 +362,7 @@ function _requestingSubtitlesChange(
if (enabled && conference?.getTranscriptionStatus() === JitsiMeetJS.constants.transcriptionStatus.OFF
&& isJwtFeatureEnabled(getState(), MEET_FEATURES.TRANSCRIPTION, false)) {
if (!conference?.getMetadataHandler()?.getMetadata()?.asyncTranscription) {
if (!backendRecordingOn) {
conference?.dial(TRANSCRIBER_DIAL_NUMBER)
.catch((e: any) => {
logger.error('Error dialing', e);
@@ -376,9 +375,7 @@ function _requestingSubtitlesChange(
}));
dispatch(setSubtitlesError(true));
});
}
if (backendRecordingOn) {
} else {
conference?.getMetadataHandler()?.setMetadata(RECORDING_METADATA_ID, {
isTranscribingEnabled: true
});