Hristo Terezov
3c7829a457
fix(DesktopPicker): Stops displaying if closed too fast.
...
If the desktop picker window is closed before we load the sources, a JS error is thrown. From there the app goes into a broken state where when the screen sharing button is pressed nothing happens. Explanation:
When the error from the _onCloseModal handler is thrown we don't reach the line to call the onSourceChoose callback. The result is that we never call the callback received by setDisplayMediaRequestHandler. It seems that when this happens on subsequent gDM calls electron won't call the setDisplayMediaRequestHandler and therefore we don't display the desktop picker.
2025-04-11 09:32:22 -05:00
damencho
ea0f9e7934
feat: Adds ts rule noImplicitOverride and fix errors.
2025-03-12 11:40:07 -05:00
Saúl Ibarra Corretgé
13bfdaed68
feat(external_api) facilitate gDM Electron
...
In order to use gDM in Electron the flow is somewhat reversed. It starts
from the Electron main process, so we need an API in the external_api
that can trigger the builtin picker. The picker is still necessary.
2025-02-13 12:12:19 +01:00
Hristo Terezov
35554533d1
fix(config): Document desktopSharingSources and improve types
2025-01-16 12:44:51 -06:00
Gabriel Borlea
0813ae0f3c
fix(electron-screensharing): get the right current selected source
2023-11-21 12:13:59 -06:00
Gabriel Borlea
97e5f00dae
fix(electron-screensharing): simplify the proccess ( #13967 )
...
* fix(electron-screensharing): simplify the proccess
2023-10-20 19:55:06 +03:00
Duduman Bogdan Vlad
8a2e4bc628
feat(screenshare) - add web security fix for electron ( #13096 )
...
use send the share screen sources using the external api
---------
Co-authored-by: Gabriel Borlea <gabriel.borlea@8x8.com >
2023-10-16 14:59:55 +03:00
Robert Pintilii
2ba6bcf172
chore(deps) Upgrade eslint ( #13341 )
...
Upgrade eslint related packages
Fix new errors
2023-05-12 13:24:50 +03:00
Christoph Settgast
1a22b7d0dd
fix(desktop-picker): Populate list of desktop app windows to share
...
Fix bug introduced via #12994 where id was changed and "-tab" was appended. Due to this the selected tab was not anymore working and empty object was returned here: 05da37b56d/react/features/desktop-picker/components/DesktopPicker.tsx (L270)
Originally part of #13096 by @dudumanbogdan, but pulled ahead to fix application
window sharing via Electron desktop app.
Fixes : jitsi/jitsi-meet-electron#857
2023-04-13 23:12:37 -05:00
Robert Pintilii
0bea2926d2
ref(TS) Convert some components to TS ( #13142 )
2023-04-04 10:21:53 +03:00
Robert Pintilii
29945f4809
ref(TS) Improve TS ( #13120 )
...
Remove unnecessary @ts-ignore
Fix some TS errors
2023-03-29 10:16:54 +03:00
Robert Pintilii
754f658489
ref(redux) Remove connect wrapper ( #13083 )
2023-03-21 09:47:52 +02:00
Emmanuel Pelletier
f727b9295f
Use tabs ARIA design pattern when using tabbed UI ( #12994 )
...
feat(a11y): use tabs ARIA design pattern when using tabbed UI
2023-03-06 17:13:29 +02:00
Robert Pintilii
df1a5a25d4
ref(desktop-picker) Replace atlaskit tabs with our component ( #12910 )
...
Fixes wrong focus on desktop picker dialog
2023-02-17 11:34:47 +02:00
Robert Pintilii
0ba033e07d
ref(TS) Improve TS ( #12612 )
...
Remove unnecessary @ts-ignores
Remove unnecessary eslint-disable
2022-11-28 12:52:45 +02:00
Robert Pintilii
b52b4c2a78
ref(TS ) Improve TS ( #12491 )
...
Remove global variables from files
Change type to interface
2022-11-03 10:35:51 +02:00
Robert Pintilii
2938d1f2dc
ref(TS) Require interfaces to start with I ( #12424 )
2022-10-20 12:11:27 +03:00
Robert Pintilii
dd6478b3cf
ref(ui-components) Use new Dialog ( #12363 )
...
Convert some files to TS
Improve Dialog component
2022-10-17 14:27:48 +03:00