log: fix log formatting

build: exit with an error if bundle sizes increase too much
The currently selected values are a bit above the actual sizes, so if a PR increases the bundle size enough to trigger the failure, it should bump it. It better have a good reason for it though!
2026-05-21 19:07:46 +00:00 · 2019-09-08 19:28:28 +02:00 · 2019-09-06 17:46:25 +02:00 · 2019-09-06 17:46:25 +02:00 · 2019-09-06 16:29:23 +02:00 · 2019-09-06 16:29:23 +02:00
16 changed files with 287 additions and 81 deletions
--- a/android/scripts/release-sdk.sh
+++ b/android/scripts/release-sdk.sh
@@ -10,6 +10,7 @@ MVN_HTTP=0
 DEFAULT_SDK_VERSION=$(grep sdkVersion ${THIS_DIR}/../gradle.properties | cut -d"=" -f2)
 SDK_VERSION=${OVERRIDE_SDK_VERSION:-${DEFAULT_SDK_VERSION}}
 RN_VERSION=$(jq -r '.dependencies."react-native"' ${THIS_DIR}/../../package.json)
+JSC_VERSION="r"$(jq -r '.dependencies."jsc-android"' ${THIS_DIR}/../../node_modules/react-native/package.json | cut -d . -f 1)
 DO_GIT_TAG=${GIT_TAG:-0}

 if [[ $THE_MVN_REPO == http* ]]; then
@@ -37,14 +38,20 @@ if [[ $MVN_HTTP == 1 ]]; then
        -DgeneratePom=false \
        -DpomFile=react-native-${RN_VERSION}.pom || true
    popd
+    # Push JSC
+    echo "Pushing JSC ${JSC_VERSION} to the Maven repo"
+    pushd ${THIS_DIR}/../../node_modules/jsc-android/dist/org/webkit/android-jsc/${JSC_VERSION}
+    mvn \
+        deploy:deploy-file \
+        -Durl=${MVN_REPO} \
+        -DrepositoryId=${MVN_REPO_ID} \
+        -Dfile=android-jsc-${JSC_VERSION}.aar \
+        -Dpackaging=aar \
+        -DgeneratePom=false \
+        -DpomFile=android-jsc-${JSC_VERSION}.pom || true
+    popd
 else
-    # Check if an SDK with that same version has already been released
-    if [[ -d ${MVN_REPO}/org/jitsi/react/jitsi-meet-sdk/${SDK_VERSION} ]]; then
-        echo "There is already a release with that version in the Maven repo!"
-        exit 1
-    fi
-
-    # First push React Native, if necessary
+    # Push React Native, if necessary
    if [[ ! -d ${MVN_REPO}/com/facebook/react/react-native/${RN_VERSION} ]]; then
        echo "Pushing React Native ${RN_VERSION} to the Maven repo"
        pushd ${THIS_DIR}/../../node_modules/react-native/android/com/facebook/react/react-native/${RN_VERSION}
@@ -57,6 +64,26 @@ else
            -DpomFile=react-native-${RN_VERSION}.pom
        popd
    fi
+
+    # Push JSC, if necessary
+    if [[ ! -d ${MVN_REPO}/org/webkit/android-jsc/${JSC_VERSION} ]]; then
+        echo "Pushing JSC ${JSC_VERSION} to the Maven repo"
+        pushd ${THIS_DIR}/../../node_modules/jsc-android/dist/org/webkit/android-jsc/${JSC_VERSION}
+        mvn \
+            deploy:deploy-file \
+            -Durl=${MVN_REPO} \
+            -Dfile=android-jsc-${JSC_VERSION}.aar \
+            -Dpackaging=aar \
+            -DgeneratePom=false \
+            -DpomFile=android-jsc-${JSC_VERSION}.pom
+        popd
+    fi
+
+    # Check if an SDK with that same version has already been released
+    if [[ -d ${MVN_REPO}/org/jitsi/react/jitsi-meet-sdk/${SDK_VERSION} ]]; then
+        echo "There is already a release with that version in the Maven repo!"
+        exit 1
+    fi
 fi

 # Now build and publish the Jitsi Meet SDK and its dependencies
--- a/android/sdk/src/main/java/org/jitsi/meet/sdk/RNConnectionService.java
+++ b/android/sdk/src/main/java/org/jitsi/meet/sdk/RNConnectionService.java
@@ -75,7 +75,7 @@ class RNConnectionService
            String handle,
            boolean hasVideo,
            Promise promise) {
-        JitsiMeetLogger.d("%d startCall UUID=%s, h=%s, v=%s",
+        JitsiMeetLogger.d("%s startCall UUID=%s, h=%s, v=%s",
                            TAG,
                            callUUID,
                            handle,
--- a/ios/Podfile.lock
+++ b/ios/Podfile.lock
@@ -144,7 +144,7 @@ PODS:
    - React
  - react-native-netinfo (4.1.5):
    - React
-  - react-native-webrtc (1.69.2):
+  - react-native-webrtc (1.75.0):
    - React
  - react-native-webview (5.8.1):
    - React
@@ -352,7 +352,7 @@ SPEC CHECKSUMS:
  react-native-calendar-events: 2fe35a9294af05de0ed819d3a1b5dac048d2c010
  react-native-keep-awake: eba3137546b10003361b37c761f6c429b59814ae
  react-native-netinfo: 8d8db463bcc5db66a8ac5c48a7d86beb3b92f61a
-  react-native-webrtc: 1415d2a54b2246dd85ba95eb3e4bf2b66533f951
+  react-native-webrtc: c5e3d631179a933548a8e49bddbd8fad02586095
  react-native-webview: a95842e3f351a6d2c8bc8bcc9eab689c7e7e5ad4
  React-RCTActionSheet: b0f1ea83f4bf75fb966eae9bfc47b78c8d3efd90
  React-RCTAnimation: 359ba1b5690b1e87cc173558a78e82d35919333e
--- a/modules/API/external/external_api.js
+++ b/modules/API/external/external_api.js
@@ -18,8 +18,6 @@ import {
    setVideoInputDevice
 } from './functions';

-const logger = require('jitsi-meet-logger').getLogger(__filename);
-
 const ALWAYS_ON_TOP_FILENAMES = [
    'css/all.css', 'libs/alwaysontop.min.js'
 ];
@@ -618,7 +616,7 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
     */
    executeCommand(name, ...args) {
        if (!(name in commands)) {
-            logger.error('Not supported command name.');
+            console.error('Not supported command name.');

            return;
        }
--- a/package-lock.json
+++ b/package-lock.json
@@ -3444,6 +3444,12 @@
        "acorn": "^5.0.3"
      }
    },
+    "acorn-walk": {
+      "version": "6.2.0",
+      "resolved": "https://registry.npmjs.org/acorn-walk/-/acorn-walk-6.2.0.tgz",
+      "integrity": "sha512-7evsyfH1cLOCdAzZAd43Cic04yKydNx0cF+7tiA19p1XnLLPU4dpCQOqpjqwokFe//vS0QqfqqjCS2JkiIs0cA==",
+      "dev": true
+    },
    "ajv": {
      "version": "5.5.2",
      "resolved": "https://registry.npmjs.org/ajv/-/ajv-5.5.2.tgz",
@@ -4413,6 +4419,26 @@
        "tweetnacl": "^0.14.3"
      }
    },
+    "bfj": {
+      "version": "6.1.2",
+      "resolved": "https://registry.npmjs.org/bfj/-/bfj-6.1.2.tgz",
+      "integrity": "sha512-BmBJa4Lip6BPRINSZ0BPEIfB1wUY/9rwbwvIHQA1KjX9om29B6id0wnWXq7m3bn5JrUVjeOTnVuhPT1FiHwPGw==",
+      "dev": true,
+      "requires": {
+        "bluebird": "^3.5.5",
+        "check-types": "^8.0.3",
+        "hoopy": "^0.1.4",
+        "tryer": "^1.0.1"
+      },
+      "dependencies": {
+        "bluebird": {
+          "version": "3.5.5",
+          "resolved": "https://registry.npmjs.org/bluebird/-/bluebird-3.5.5.tgz",
+          "integrity": "sha512-5am6HnnfN+urzt4yfg7IgTbotDjIT/u8AJpEt0sIU9FtXfVeezXAPKswrG+xKUCOYAINpSdgZVDU6QFh+cuH3w==",
+          "dev": true
+        }
+      }
+    },
    "big-integer": {
      "version": "1.6.44",
      "resolved": "https://registry.npmjs.org/big-integer/-/big-integer-1.6.44.tgz",
@@ -4835,6 +4861,12 @@
      "resolved": "https://registry.npmjs.org/chardet/-/chardet-0.4.2.tgz",
      "integrity": "sha1-tUc7M9yXxCTl2Y3IfVXU2KKci/I="
    },
+    "check-types": {
+      "version": "8.0.3",
+      "resolved": "https://registry.npmjs.org/check-types/-/check-types-8.0.3.tgz",
+      "integrity": "sha512-YpeKZngUmG65rLudJ4taU7VLkOCTMhNl/u4ctNC56LQS/zJTyNH0Lrtwm1tfTsbLlwvlfsA2d1c8vCf/Kh2KwQ==",
+      "dev": true
+    },
    "chokidar": {
      "version": "2.0.4",
      "resolved": "https://registry.npmjs.org/chokidar/-/chokidar-2.0.4.tgz",
@@ -6083,6 +6115,12 @@
        "moment": "^2.19.3"
      }
    },
+    "duplexer": {
+      "version": "0.1.1",
+      "resolved": "https://registry.npmjs.org/duplexer/-/duplexer-0.1.1.tgz",
+      "integrity": "sha1-rOb/gIwc5mtX0ev5eXessCM0z8E=",
+      "dev": true
+    },
    "duplexify": {
      "version": "3.5.4",
      "resolved": "https://registry.npmjs.org/duplexify/-/duplexify-3.5.4.tgz",
@@ -6142,6 +6180,12 @@
      "resolved": "https://registry.npmjs.org/ee-first/-/ee-first-1.1.1.tgz",
      "integrity": "sha1-WQxhFWsK4vTwJVcyoViyZrxWsh0="
    },
+    "ejs": {
+      "version": "2.7.1",
+      "resolved": "https://registry.npmjs.org/ejs/-/ejs-2.7.1.tgz",
+      "integrity": "sha512-kS/gEPzZs3Y1rRsbGX4UOSjtP/CeJP0CxSNZHYxGfVM/VgLcv0ZqM7C45YyTj2DI2g7+P9Dd24C+IMIg6D0nYQ==",
+      "dev": true
+    },
    "electron-to-chromium": {
      "version": "1.3.34",
      "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.3.34.tgz",
@@ -7220,6 +7264,12 @@
        "object-assign": "^4.0.1"
      }
    },
+    "filesize": {
+      "version": "3.6.1",
+      "resolved": "https://registry.npmjs.org/filesize/-/filesize-3.6.1.tgz",
+      "integrity": "sha512-7KjR1vv6qnicaPMi1iiTcI85CyYwRO/PSFCu6SvqL8jN2Wjt/NIYQTFtFs7fSDCYOstUkEWIQGFUg5YZQfjlcg==",
+      "dev": true
+    },
    "fill-range": {
      "version": "4.0.0",
      "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-4.0.0.tgz",
@@ -8253,6 +8303,24 @@
      "resolved": "https://registry.npmjs.org/gud/-/gud-1.0.0.tgz",
      "integrity": "sha512-zGEOVKFM5sVPPrYs7J5/hYEw2Pof8KCyOwyhG8sAF26mCAeUFAcYPu1mwB7hhpIP29zOIBaDqwuHdLp0jvZXjw=="
    },
+    "gzip-size": {
+      "version": "5.1.1",
+      "resolved": "https://registry.npmjs.org/gzip-size/-/gzip-size-5.1.1.tgz",
+      "integrity": "sha512-FNHi6mmoHvs1mxZAds4PpdCS6QG8B4C1krxJsMutgxl5t3+GlRTzzI3NEkifXx2pVsOvJdOGSmIgDhQ55FwdPA==",
+      "dev": true,
+      "requires": {
+        "duplexer": "^0.1.1",
+        "pify": "^4.0.1"
+      },
+      "dependencies": {
+        "pify": {
+          "version": "4.0.1",
+          "resolved": "https://registry.npmjs.org/pify/-/pify-4.0.1.tgz",
+          "integrity": "sha512-uB80kBFb/tfd68bVleG9T5GGsGPjJrLAUpR5PZIrhBnIaRTQRjqdJSsIKkOP6OAIFbj7GOrcudc5pNjZ+geV2g==",
+          "dev": true
+        }
+      }
+    },
    "handle-thing": {
      "version": "2.0.0",
      "resolved": "https://registry.npmjs.org/handle-thing/-/handle-thing-2.0.0.tgz",
@@ -8432,6 +8500,12 @@
        }
      }
    },
+    "hoopy": {
+      "version": "0.1.4",
+      "resolved": "https://registry.npmjs.org/hoopy/-/hoopy-0.1.4.tgz",
+      "integrity": "sha512-HRcs+2mr52W0K+x8RzcLzuPPmVIKMSv97RGHy0Ea9y/mpcaK+xTrjICA04KAHi4GRzxliNqNJEFYWHghy3rSfQ==",
+      "dev": true
+    },
    "hosted-git-info": {
      "version": "2.5.0",
      "resolved": "https://registry.npmjs.org/hosted-git-info/-/hosted-git-info-2.5.0.tgz",
@@ -10565,8 +10639,8 @@
      }
    },
    "lib-jitsi-meet": {
-      "version": "github:jitsi/lib-jitsi-meet#00920c0f655a74c757c7fef2cdbd053ae4d1f485",
-      "from": "github:jitsi/lib-jitsi-meet#00920c0f655a74c757c7fef2cdbd053ae4d1f485",
+      "version": "github:jitsi/lib-jitsi-meet#486c61e2a91eeb3d9b6f179ea0c82044e321dccf",
+      "from": "github:jitsi/lib-jitsi-meet#486c61e2a91eeb3d9b6f179ea0c82044e321dccf",
      "requires": {
        "@jitsi/sdp-interop": "0.1.14",
        "@jitsi/sdp-simulcast": "0.2.2",
@@ -12436,6 +12510,12 @@
        "is-wsl": "^1.1.0"
      }
    },
+    "opener": {
+      "version": "1.5.1",
+      "resolved": "https://registry.npmjs.org/opener/-/opener-1.5.1.tgz",
+      "integrity": "sha512-goYSy5c2UXE4Ra1xixabeVh1guIX/ZV/YokJksb6q2lubWu6UbvPQ20p542/sFIll1nl8JnCyK9oBaOcCWXwvA==",
+      "dev": true
+    },
    "optionator": {
      "version": "0.8.2",
      "resolved": "https://registry.npmjs.org/optionator/-/optionator-0.8.2.tgz",
@@ -14274,8 +14354,8 @@
      "integrity": "sha512-l3Quzbb+qa4in2U5RSt/lT0/pHrIpEChT1NnqrVAAXNrjkXjVOsxduaaEDdDhTzNJQEm/PcAcoyrFmgvGOohxw=="
    },
    "react-native-webrtc": {
-      "version": "github:jitsi/react-native-webrtc#44ecfddfa816d260087e16c92f299ded169a4472",
-      "from": "github:jitsi/react-native-webrtc#44ecfddfa816d260087e16c92f299ded169a4472",
+      "version": "github:react-native-webrtc/react-native-webrtc#b1275ccf1e0e083d2a5c238e7d21c37657766463",
+      "from": "github:react-native-webrtc/react-native-webrtc#b1275ccf1e0e083d2a5c238e7d21c37657766463",
      "requires": {
        "base64-js": "^1.1.2",
        "event-target-shim": "^1.0.5",
@@ -14284,9 +14364,9 @@
      },
      "dependencies": {
        "uuid": {
-          "version": "3.3.2",
-          "resolved": "https://registry.npmjs.org/uuid/-/uuid-3.3.2.tgz",
-          "integrity": "sha512-yXJmeNaw3DnnKAOKJE51sL/ZaYfWJRl1pK9dr19YFCu0ObS231AB1/LbqTKRAQ5kw8A90rA6fr4riOUpTZvQZA=="
+          "version": "3.3.3",
+          "resolved": "https://registry.npmjs.org/uuid/-/uuid-3.3.3.tgz",
+          "integrity": "sha512-pW0No1RGHgzlpHJO1nsVrHKpOEIxkGg1xB+v0ZmdNH5OAeAwzAVrCnI2/6Mtx+Uys6iaylxa+D3g4j63IKKjSQ=="
        }
      }
    },
@@ -17109,6 +17189,12 @@
        "glob": "^7.1.2"
      }
    },
+    "tryer": {
+      "version": "1.0.1",
+      "resolved": "https://registry.npmjs.org/tryer/-/tryer-1.0.1.tgz",
+      "integrity": "sha512-c3zayb8/kWWpycWYg87P71E1S1ZL6b6IJxfb5fvsUgsf0S2MVGaDhDXXjDMpdCpfWXqptc+4mXwmiy1ypXqRAA==",
+      "dev": true
+    },
    "tslib": {
      "version": "1.9.3",
      "resolved": "https://registry.npmjs.org/tslib/-/tslib-1.9.3.tgz",
@@ -17945,6 +18031,85 @@
        }
      }
    },
+    "webpack-bundle-analyzer": {
+      "version": "3.4.1",
+      "resolved": "https://registry.npmjs.org/webpack-bundle-analyzer/-/webpack-bundle-analyzer-3.4.1.tgz",
+      "integrity": "sha512-Bs8D/1zF+17lhqj2OYmzi7HEVYqEVxu7lCO9Ff8BwajenOU0vAwEoV8e4ICCPNZAcqR1PCR/7o2SkW+cnCmF0A==",
+      "dev": true,
+      "requires": {
+        "acorn": "^6.0.7",
+        "acorn-walk": "^6.1.1",
+        "bfj": "^6.1.1",
+        "chalk": "^2.4.1",
+        "commander": "^2.18.0",
+        "ejs": "^2.6.1",
+        "express": "^4.16.3",
+        "filesize": "^3.6.1",
+        "gzip-size": "^5.0.0",
+        "lodash": "^4.17.15",
+        "mkdirp": "^0.5.1",
+        "opener": "^1.5.1",
+        "ws": "^6.0.0"
+      },
+      "dependencies": {
+        "acorn": {
+          "version": "6.3.0",
+          "resolved": "https://registry.npmjs.org/acorn/-/acorn-6.3.0.tgz",
+          "integrity": "sha512-/czfa8BwS88b9gWQVhc8eknunSA2DoJpJyTQkhheIf5E48u1N0R4q/YxxsAeqRrmK9TQ/uYfgLDfZo91UlANIA==",
+          "dev": true
+        },
+        "ansi-styles": {
+          "version": "3.2.1",
+          "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz",
+          "integrity": "sha512-VT0ZI6kZRdTh8YyJw3SMbYm/u+NqfsAxEpWO0Pf9sq8/e94WxxOpPKx9FR1FlyCtOVDNOQ+8ntlqFxiRc+r5qA==",
+          "dev": true,
+          "requires": {
+            "color-convert": "^1.9.0"
+          }
+        },
+        "chalk": {
+          "version": "2.4.2",
+          "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz",
+          "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==",
+          "dev": true,
+          "requires": {
+            "ansi-styles": "^3.2.1",
+            "escape-string-regexp": "^1.0.5",
+            "supports-color": "^5.3.0"
+          }
+        },
+        "has-flag": {
+          "version": "3.0.0",
+          "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz",
+          "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=",
+          "dev": true
+        },
+        "lodash": {
+          "version": "4.17.15",
+          "resolved": "https://registry.npmjs.org/lodash/-/lodash-4.17.15.tgz",
+          "integrity": "sha512-8xOcRHvCjnocdS5cpwXQXVzmmh5e5+saE2QGoeQmbKmRS6J3VQppPOIt0MnmE+4xlZoumy0GPG0D0MVIQbNA1A==",
+          "dev": true
+        },
+        "supports-color": {
+          "version": "5.5.0",
+          "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz",
+          "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==",
+          "dev": true,
+          "requires": {
+            "has-flag": "^3.0.0"
+          }
+        },
+        "ws": {
+          "version": "6.2.1",
+          "resolved": "https://registry.npmjs.org/ws/-/ws-6.2.1.tgz",
+          "integrity": "sha512-GIyAXC2cB7LjvpgMt9EKS2ldqr0MTrORaleiOno6TweZ6r3TKtoFQWay/2PceJ3RuBasOHzXNn5Lrw1X0bEjqA==",
+          "dev": true,
+          "requires": {
+            "async-limiter": "~1.0.0"
+          }
+        }
+      }
+    },
    "webpack-cli": {
      "version": "3.1.2",
      "resolved": "https://registry.npmjs.org/webpack-cli/-/webpack-cli-3.1.2.tgz",
--- a/package.json
+++ b/package.json
@@ -55,7 +55,7 @@
    "js-utils": "github:jitsi/js-utils#192b1c996e8c05530eb1f19e82a31069c3021e31",
    "jsrsasign": "8.0.12",
    "jwt-decode": "2.2.0",
-    "lib-jitsi-meet": "github:jitsi/lib-jitsi-meet#00920c0f655a74c757c7fef2cdbd053ae4d1f485",
+    "lib-jitsi-meet": "github:jitsi/lib-jitsi-meet#486c61e2a91eeb3d9b6f179ea0c82044e321dccf",
    "libflacjs": "github:mmig/libflac.js#93d37e7f811f01cf7d8b6a603e38bd3c3810907d",
    "lodash": "4.17.13",
    "moment": "2.19.4",
@@ -78,7 +78,7 @@
    "react-native-swipeout": "2.3.6",
    "react-native-vector-icons": "6.0.2",
    "react-native-watch-connectivity": "0.2.0",
-    "react-native-webrtc": "github:jitsi/react-native-webrtc#44ecfddfa816d260087e16c92f299ded169a4472",
+    "react-native-webrtc": "github:react-native-webrtc/react-native-webrtc#b1275ccf1e0e083d2a5c238e7d21c37657766463",
    "react-native-webview": "5.8.1",
    "react-redux": "7.1.0",
    "react-textarea-autosize": "7.1.0",
@@ -124,6 +124,7 @@
    "string-replace-loader": "2.1.1",
    "style-loader": "0.19.0",
    "webpack": "4.26.1",
+    "webpack-bundle-analyzer": "3.4.1",
    "webpack-cli": "3.1.2",
    "webpack-dev-server": "3.1.14"
  },
--- a/react/features/always-on-top/AudioMuteButton.js
+++ b/react/features/always-on-top/AudioMuteButton.js
@@ -5,8 +5,6 @@
 import AbstractAudioMuteButton from '../base/toolbox/components/AbstractAudioMuteButton';
 import type { Props } from '../base/toolbox/components/AbstractButton';

-import logger from './logger';
-
 const { api } = window.alwaysOnTop;

 /**
@@ -72,7 +70,7 @@ export default class AudioMuteButton
                    audioAvailable,
                    audioMuted
                }))
-            .catch(logger.error);
+            .catch(console.error);
    }

    /**
--- a/react/features/always-on-top/VideoMuteButton.js
+++ b/react/features/always-on-top/VideoMuteButton.js
@@ -5,8 +5,6 @@
 import AbstractVideoMuteButton from '../base/toolbox/components/AbstractVideoMuteButton';
 import type { Props } from '../base/toolbox/components/AbstractButton';

-import logger from './logger';
-
 const { api } = window.alwaysOnTop;

 /**
@@ -72,7 +70,7 @@ export default class VideoMuteButton
                    videoAvailable,
                    videoMuted
                }))
-            .catch(logger.error);
+            .catch(console.error);
    }

    /**
--- a/react/features/always-on-top/logger.js
+++ b/react/features/always-on-top/logger.js
@@ -1,3 +0,0 @@
-import { getLogger } from '../base/logging/functions';
-
-export default getLogger('features/always-on-top');
--- a/react/features/base/util/helpers.js
+++ b/react/features/base/util/helpers.js
@@ -1,7 +1,5 @@
 // @flow

-import logger from './logger';
-
 /**
 * Creates a deferred object.
 *
@@ -106,6 +104,6 @@ export function assignIfDefined(target: Object, source: Object) {
 * @returns {void}
 */
 export function reportError(e: Object, msg: string = '') {
-    logger.error(msg, e);
+    console.error(msg, e);
    window.onerror && window.onerror(msg, null, null, null, e);
 }
--- a/react/features/base/util/httpUtils.js
+++ b/react/features/base/util/httpUtils.js
@@ -1,7 +1,5 @@
 import { timeoutPromise } from './timeoutPromise';

-import logger from './logger';
-
 /**
 * The number of milliseconds before deciding that we need retry a fetch request.
 *
@@ -29,11 +27,6 @@ export function doGetJSON(url, retry) {

            return jsonify
                .then(result => Promise.reject(result));
-        })
-        .catch(error => {
-            logger.error('Error performing get:', url, error);
-
-            return Promise.reject(error);
        });

    if (retry) {
--- a/react/features/base/util/logger.js
+++ b/react/features/base/util/logger.js
@@ -1,5 +0,0 @@
-// @flow
-
-import { getLogger } from '../logging/functions';
-
-export default getLogger('features/base/util');
--- a/react/features/base/util/uri.js
+++ b/react/features/base/util/uri.js
@@ -1,7 +1,5 @@
 // @flow

-import logger from './logger';
-
 /**
 * The app linking scheme.
 * TODO: This should be read from the manifest files later.
@@ -133,7 +131,7 @@ function _objectToURLParamsArray(obj = {}) {
            params.push(
                `${key}=${encodeURIComponent(JSON.stringify(obj[key]))}`);
        } catch (e) {
-            logger.warn(`Error encoding ${key}: ${e}`);
+            console.warn(`Error encoding ${key}: ${e}`);
        }
    }

--- a/react/features/invite/components/dial-in-info-page/DialInInfoApp.web.js
+++ b/react/features/invite/components/dial-in-info-page/DialInInfoApp.web.js
@@ -8,7 +8,7 @@ import { i18next } from '../../../base/i18n';
 import { DialInSummary } from '../dial-in-summary';

 import NoRoomError from './NoRoomError';
-import { Platform } from '../../../base/react';
+import Platform from '../../../base/react/Platform.web';

 document.addEventListener('DOMContentLoaded', () => {
    const { room } = parseURLParams(window.location, true, 'search');
--- a/react/features/local-recording/recording/flac/flacEncodeWorker.js
+++ b/react/features/local-recording/recording/flac/flacEncodeWorker.js
@@ -1,4 +1,4 @@
-import logger from '../../logger';
+
 import {
    MAIN_THREAD_FINISH,
    MAIN_THREAD_INIT,
@@ -262,7 +262,7 @@ class Encoder {
            const errorNo
                = Flac.FLAC__stream_encoder_get_state(this._encoderId);

-            logger.error('Error during encoding', FLAC_ERRORS[errorNo]);
+            console.error('Error during encoding', FLAC_ERRORS[errorNo]);
        }
    }

@@ -277,7 +277,7 @@ class Encoder {

            const status = Flac.FLAC__stream_encoder_finish(this._encoderId);

-            logger.log('Flac encoding finished: ', status);
+            console.log('Flac encoding finished: ', status);

            // free up resources
            Flac.FLAC__stream_encoder_delete(this._encoderId);
@@ -371,8 +371,7 @@ self.onmessage = function(e) {

    case MAIN_THREAD_NEW_DATA_ARRIVED:
        if (encoder === null) {
-            logger.error('flacEncoderWorker received data when the encoder is'
-                + 'not ready.');
+            console.error('flacEncoderWorker received data when the encoder is not ready.');
        } else {
            encoder.encode(e.data.buf);
        }
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -1,6 +1,7 @@
 /* global __dirname */

 const process = require('process');
+const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');

 /**
 * The URL of the Jitsi Meet deployment to be proxy to in the context of
@@ -9,10 +10,24 @@ const process = require('process');
 const devServerProxyTarget
    = process.env.WEBPACK_DEV_SERVER_PROXY_TARGET || 'https://beta.meet.jit.si';

+const analyzeBundle = process.argv.indexOf('--analyze-bundle') !== -1;
+
 const minimize
    = process.argv.indexOf('-p') !== -1
        || process.argv.indexOf('--optimize-minimize') !== -1;

+/**
+ * Build a Performance configuration object for the given size.
+ * See: https://webpack.js.org/configuration/performance/
+ */
+function getPerformanceHints(size) {
+    return {
+        hints: minimize ? 'error' : false,
+        maxAssetSize: size,
+        maxEntrypointSize: size
+    };
+}
+
 // The base Webpack configuration to bundle the JavaScript artifacts of
 // jitsi-meet such as app.bundle.js and external_api.js.
 const config = {
@@ -123,6 +138,13 @@ const config = {
        publicPath: '/libs/',
        sourceMapFilename: `[name].${minimize ? 'min' : 'js'}.map`
    },
+    plugins: [
+        analyzeBundle
+            && new BundleAnalyzerPlugin({
+                analyzerMode: 'disabled',
+                generateStatsFile: true
+            })
+    ].filter(Boolean),
    resolve: {
        alias: {
            jquery: `jquery/dist/jquery${minimize ? '.min' : ''}.js`
@@ -143,27 +165,45 @@ const config = {
 module.exports = [
    Object.assign({}, config, {
        entry: {
-            'app.bundle': './app.js',
-
-            'device_selection_popup_bundle':
-                './react/features/settings/popup.js',
-
-            'alwaysontop':
-                './react/features/always-on-top/index.js',
-
-            'dial_in_info_bundle': [
-                './react/features/invite/components/dial-in-info-page'
-            ],
-
-            'do_external_connect':
-                './connection_optimization/do_external_connect.js',
-
-            'flacEncodeWorker':
-                './react/features/local-recording/'
-                    + 'recording/flac/flacEncodeWorker.js',
-            'analytics-ga':
-                './react/features/analytics/handlers/GoogleAnalyticsHandler.js'
-        }
+            'app.bundle': './app.js'
+        },
+        performance: getPerformanceHints(3 * 1024 * 1024)
+    }),
+    Object.assign({}, config, {
+        entry: {
+            'device_selection_popup_bundle': './react/features/settings/popup.js'
+        },
+        performance: getPerformanceHints(2.5 * 1024 * 1024)
+    }),
+    Object.assign({}, config, {
+        entry: {
+            'alwaysontop': './react/features/always-on-top/index.js'
+        },
+        performance: getPerformanceHints(400 * 1024)
+    }),
+    Object.assign({}, config, {
+        entry: {
+            'dial_in_info_bundle': './react/features/invite/components/dial-in-info-page'
+        },
+        performance: getPerformanceHints(500 * 1024)
+    }),
+    Object.assign({}, config, {
+        entry: {
+            'do_external_connect': './connection_optimization/do_external_connect.js'
+        },
+        performance: getPerformanceHints(5 * 1024)
+    }),
+    Object.assign({}, config, {
+        entry: {
+            'flacEncodeWorker': './react/features/local-recording/recording/flac/flacEncodeWorker.js'
+        },
+        performance: getPerformanceHints(5 * 1024)
+    }),
+    Object.assign({}, config, {
+        entry: {
+            'analytics-ga': './react/features/analytics/handlers/GoogleAnalyticsHandler.js'
+        },
+        performance: getPerformanceHints(5 * 1024)
    }),
    Object.assign({}, config, {
        entry: {
@@ -172,11 +212,9 @@ module.exports = [
        output: Object.assign({}, config.output, {
            library: [ 'JitsiMeetJS', 'app', 'effects' ],
            libraryTarget: 'window'
-        })
+        }),
+        performance: getPerformanceHints(1 * 1024 * 1024)
    }),
-
-    // The Webpack configuration to bundle external_api.js (aka
-    // JitsiMeetExternalAPI).
    Object.assign({}, config, {
        entry: {
            'external_api': './modules/API/external/index.js'
@@ -184,7 +222,8 @@ module.exports = [
        output: Object.assign({}, config.output, {
            library: 'JitsiMeetExternalAPI',
            libraryTarget: 'umd'
-        })
+        }),
+        performance: getPerformanceHints(30 * 1024)
    })
 ];
Author	SHA1	Message	Date
Saúl Ibarra Corretgé	d9da14ab12	log: fix log formatting	2019-09-08 19:28:28 +02:00
Saúl Ibarra Corretgé	f6fb859531	build: exit with an error if bundle sizes increase too much The currently selected values are a bit above the actual sizes, so if a PR increases the bundle size enough to trigger the failure, it should bump it. It better have a good reason for it though!	2019-09-06 17:46:25 +02:00
Saúl Ibarra Corretgé	7deb2006c3	build: add integration with webpack-bundle-analyzer Build as follows to build (production) bundle size stats: npx webpack -p --progress --analyze-bundle Then open the report: npx webpack-bundle-analyzer build/stats.json build/	2019-09-06 17:46:25 +02:00
Saúl Ibarra Corretgé	2aea24ffad	dial-in-info: fix bundle bloat The direct import sidesteps many chained-effect imports, halving the bundle size.	2019-09-06 16:29:23 +02:00
Saúl Ibarra Corretgé	b5aae0b58d	build: style	2019-09-06 16:29:23 +02:00
Saúl Ibarra Corretgé	d436825a45	flacworker: don't use the Grand Unified Logger There are just a couple of logs in this feature, and it's a standalone bundle, which would bloat it due to cascaded dependencis.	2019-09-06 16:29:23 +02:00
Saúl Ibarra Corretgé	5276cb6bc8	alwaysontop: don't use the Grand Unified Logger There are just a couple of logs in this feature, and it's a standalone bundle, which would bloat it due to cascaded dependencis.	2019-09-06 16:29:23 +02:00
Saúl Ibarra Corretgé	f863733dd3	base/util: don't use the Grand Unified Logger There are just a couple of logs in this feature, and it's included in bundles like external_api, which would bloat it due to cascaded dependencis.	2019-09-06 16:29:23 +02:00
Saúl Ibarra Corretgé	2ccd4968a4	external_api: don't use the Jitsi Meet logger This is for other applications to use, and it's currently only used for logging 1 line, so use console.error.	2019-09-06 16:29:23 +02:00
Saúl Ibarra Corretgé	c233433243	deps: react-native-webrtc@latest	2019-09-05 16:37:51 +02:00
Saúl Ibarra Corretgé	6861f463b3	android: update SDK release script to publish JSC artifacts In `b53a034aaf (diff-0339cf92cc68bc5981fe6df601316c1c)` I removed this, because RN has updated the builtin JSC version. On the next release, however, RN introduced a new JS interpreter (Hermes) so JSC is now a RN dependency. Thus, add the magic spells to publish the AARs to Maven.	2019-09-05 16:32:53 +02:00
Hristo Terezov	ac065f0225	chore(package.json): Update LJM	2019-09-05 04:33:02 -07:00
Saúl Ibarra Corretgé	b4b33c94dd	ios: update Podfile.lock	2019-09-05 12:53:26 +02:00
Saúl Ibarra Corretgé	c8753230a4	deps: react-native-webrtc@latest	2019-09-04 20:27:33 +02:00