Compare commits

...

5 Commits

Author SHA1 Message Date
George Politis
402eed5150 deps: lib-jitsi-meet@latest 2020-07-13 12:09:17 +02:00
George Politis
b3bb0725ad wip: Fixes lint errors 2020-07-13 12:06:51 +02:00
George Politis
7d845a4982 wip: Makes the max enabled resolution title a translateable string. 2020-07-13 12:06:51 +02:00
George Politis
9d1ea76162 wip: Fixes lint errors 2020-07-13 12:06:51 +02:00
George Politis
22b5bfcea4 feat: Exposes the max enabled resolution in the connection stats popover. 2020-07-13 12:06:50 +02:00
4 changed files with 18 additions and 3 deletions

View File

@@ -110,6 +110,7 @@
"localaddress_plural": "Local addresses:",
"localport": "Local port:",
"localport_plural": "Local ports:",
"maxEnabledResolution": "send max",
"more": "Show more",
"packetloss": "Packet loss:",
"quality": {

View File

@@ -56,7 +56,7 @@
"jquery-i18next": "1.2.1",
"js-md5": "0.6.1",
"jwt-decode": "2.2.0",
"lib-jitsi-meet": "github:jitsi/lib-jitsi-meet#cd008d726f1f57562eb5d8e6a3cd91c7e69826a0",
"lib-jitsi-meet": "github:jitsi/lib-jitsi-meet#304b0a2b4e18216d792f499c74fc24bc3849303e",
"libflacjs": "github:mmig/libflac.js#93d37e7f811f01cf7d8b6a603e38bd3c3810907d",
"lodash": "4.17.13",
"moment": "2.19.4",

View File

@@ -342,6 +342,7 @@ class ConnectionIndicator extends AbstractConnectionIndicator<Props, State> {
bridgeCount,
e2eRtt,
framerate,
maxEnabledResolution,
packetLoss,
region,
resolution,
@@ -358,6 +359,7 @@ class ConnectionIndicator extends AbstractConnectionIndicator<Props, State> {
e2eRtt = { e2eRtt }
framerate = { framerate }
isLocalVideo = { this.props.isLocalVideo }
maxEnabledResolution = { maxEnabledResolution }
onShowMore = { this._onToggleShowMore }
packetLoss = { packetLoss }
region = { region }

View File

@@ -57,6 +57,12 @@ type Props = {
*/
isLocalVideo: boolean,
/**
* The send-side max enabled resolution (aka the highest layer that is not
* suspended on the send-side).
*/
maxEnabledResolution: number,
/**
* Callback to invoke when the show additional stats link is clicked.
*/
@@ -380,8 +386,8 @@ class ConnectionStatsTable extends Component<Props> {
* @returns {ReactElement}
*/
_renderResolution() {
const { resolution, t } = this.props;
const resolutionString = Object.keys(resolution || {})
const { resolution, maxEnabledResolution, t } = this.props;
let resolutionString = Object.keys(resolution || {})
.map(ssrc => {
const { width, height } = resolution[ssrc];
@@ -389,6 +395,12 @@ class ConnectionStatsTable extends Component<Props> {
})
.join(', ') || 'N/A';
if (maxEnabledResolution && maxEnabledResolution < 720) {
const maxEnabledResolutionTitle = t('connectionindicator.maxEnabledResolution');
resolutionString += ` (${maxEnabledResolutionTitle} ${maxEnabledResolution}p)`;
}
return (
<tr>
<td>